Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize errors in enrollment controller #183

Merged
merged 7 commits into from
Aug 17, 2023

Conversation

danielsp45
Copy link
Member

No description provided.

@danielsp45
Copy link
Member Author

Do you think I should create a struct to allow for more personalised error reports? Maybe something like this:
{:error, %Bokken.EventsError{reason: :enrollments_closed, details: "Enrollments are closed"}}

Or do you think this is unnecessary?

lib/bokken/events.ex Outdated Show resolved Hide resolved
lib/bokken/events/enrollment.ex Outdated Show resolved Hide resolved
@danielsp45 danielsp45 force-pushed the dp/refactor-enrollment-controller branch 2 times, most recently from 258848d to 4709a05 Compare July 2, 2023 11:36
@danielsp45 danielsp45 force-pushed the dp/refactor-enrollment-controller branch from 4709a05 to d422afc Compare July 2, 2023 11:43
@danielsp45 danielsp45 force-pushed the dp/refactor-enrollment-controller branch from 085062b to 5dfd7ce Compare August 14, 2023 18:25
@danielsp45 danielsp45 marked this pull request as ready for review August 15, 2023 08:37
lib/bokken/events.ex Outdated Show resolved Hide resolved
@danielsp45 danielsp45 merged commit 726cfe1 into main Aug 17, 2023
2 checks passed
@danielsp45 danielsp45 deleted the dp/refactor-enrollment-controller branch August 17, 2023 11:19
@danielsp45 danielsp45 self-assigned this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants